-
Notifications
You must be signed in to change notification settings - Fork 485
install: remove nvidia-nvshmem-cu12 from package dependency #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The dependency is not required because: * For x86_64 user environments that installs pytorch from pypi, nvidia-nvshmem-cu12 is already a torch dependency (https://github.com/pytorch/pytorch/blob/3f1636ebef9b45e8a3cb0eb20d327ee6acb74be0/.github/scripts/generate_binary_build_matrix.py#L44-L95), and flashinfer depends on torch, there is no need to specify another nvidia-nvshmem-cu12 dependency in flashinfer. * For user environments where nvidia-nvshmem-cu12 is not a torch dependency (like in nvidia's pytorch container), nvshmem is installed at system wide. Fixes flashinfer-ai#1387 Signed-off-by: Emilien Macchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @EmilienM, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've streamlined the project's dependencies by removing a redundant package. This change ensures that the installation process is more efficient and avoids conflicts or unnecessary installations, as the dependency is either already handled transitively or provided by the system environment.
Highlights
- Dependency Management: I've removed
nvidia-nvshmem-cu12
from theinstall_requires
list insetup.py
. This dependency is no longer explicitly required because for PyTorch installations from PyPI, it's already a transitive dependency, and in environments like NVIDIA's PyTorch containers,nvshmem
is typically installed system-wide.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes nvidia-nvshmem-cu12
from the project's dependencies in setup.py
. The rationale is sound, as this package is typically a transitive dependency of PyTorch or is pre-installed in containerized environments. My review identifies one area for improvement: the same dependency is still explicitly installed in docker/install/install_python_packages.sh
. To ensure consistency and prevent potential dependency conflicts, this should also be removed.
@@ -61,7 +61,6 @@ def generate_build_meta(aot_build_meta: dict) -> None: | |||
"cuda-python", | |||
"pynvml", | |||
"einops", | |||
"nvidia-nvshmem-cu12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EmilienM The change you linked is not in pytorch 2.8 and 2.7 branch: https://github.com/pytorch/pytorch/blob/v2.8.0/.github/scripts/generate_binary_build_matrix.py#L73. So I don't think any published pytorch wheel has |
📌 Description
The dependency is not required because:
(https://github.com/pytorch/pytorch/blob/3f1636ebef9b45e8a3cb0eb20d327ee6acb74be0/.github/scripts/generate_binary_build_matrix.py#L44-L95),
and flashinfer depends on torch, there is no need to specify another nvidia-nvshmem-cu12 dependency in flashinfer.
nvshmem is installed at system wide.
🔍 Related Issues
Fixes #1387
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commit
by runningpip install pre-commit
(or used your preferred method).pre-commit install
.pre-commit run --all-files
and fixed any reported issues.🧪 Tests
unittest
, etc.).