This repository was archived by the owner on Nov 27, 2024. It is now read-only.
first pass lido classifiers #216
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick draft looking for some feedback. Contracts found here
https://github.com/lidofinance/lido-dao
Changes found in this PR are just classifiers written with the deployments found above and the associated abis. Need some guidance on testing swaps. Most interactions with the contracts are approvals and transfers (ex: LDO Token). Transfers are just moving one asset from address A to address B but not a swap from/to LDO. Not sure how to add tests for this.
@lukevs