chore: Tag logs with the relay URLs in getPayload #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharath-123
commented
Nov 11, 2025
|
|
||
| // If the request fails, try again a few times with 100ms between tries | ||
| resp, err := retry(requestCtx, m.requestMaxRetries, 100*time.Millisecond, func() (*http.Response, error) { | ||
| log = log.WithField("url", url) |
Collaborator
Author
There was a problem hiding this comment.
This was not right since it can cause a race condition with other getPayload invocations.
Collaborator
There was a problem hiding this comment.
Wouldn't it be better to create a new logger instance there, instead of adding url to every single log call?
ie. _log = log.WithField...
Collaborator
Author
There was a problem hiding this comment.
The log is a pointer and each go-routine would override that pointer. this can cause a race conditions amongst multiple getPayload calls where we see the wrong url for the wrong invocation.
bharath-123
force-pushed
the
add-urls-to-log
branch
from
cde7166 to
37dea18
Compare
jtraglia
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Tag logs with relay URLs in getPayload for better readability.
we call getPayload parallely across multiple relays and it can get hard to identify which log is coming from which relay invocation. Tagging the logs by URLs can help us understand the logs better!
✅ I have run these commands
make lintmake test-racego mod tidy