This repository was archived by the owner on Oct 25, 2024. It is now read-only.
mev share #74
Merged
mev share #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* basic sbundle * sbundle pool * sbundle api * local builder * move sim bundle to core * working builder * db for sbundles * report sbundle stat * mev_simBundle nested logs * refundConfig * pay kickback from refundable value * lints * percentof * sbundle pool with separate lock * don't wait for error when adding sbundle
* don't touch header in SimBundle * fix consolecmd test * fix log extraction
* control inclusion in sim bundle * use mevGasPrice in mev_simBundle
Ruteri
approved these changes
Jun 5, 2023
Wazzymandias
reviewed
Jun 5, 2023
| TotalProfit *big.Int | ||
| RefundableValue *big.Int | ||
| GasUsed uint64 | ||
| MevGasPrice *big.Int |
Contributor
There was a problem hiding this comment.
Could we add a small, concise godoc on what MevGasPrice means?
Wazzymandias
reviewed
Jun 5, 2023
| ErrIncorrectRefundConfig = errors.New("incorrect refund config") | ||
| ) | ||
|
|
||
| type SBundle struct { |
Contributor
There was a problem hiding this comment.
could we add a small concise godoc on SBundle ?
Specifically what the S denotes, and how it's different from a regular bundle or transaction
Wazzymandias
approved these changes
Jun 6, 2023
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
New kind of bundle added. (`SBundle`) This bundle supports validity conditions such as refunds. * bundle is supported in the builder, txpool * api `mev_sendBundle` is used to accept this bundles * api `mev_cancelBundleByHash` is used to remove bundle from pool * api `mev_simBundle` is used to simulate this kind of bundle
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Implements mev-share builder.
📚 References
CONTRIBUTING.md