Skip to content

Conversation

@Pedr0Rocha
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe: Compatibility issue with NestJS 10

What is the current behavior?

Issue Number: #488

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Pedr0Rocha
Copy link
Contributor Author

Replaced the deprecated stuff from @nestjs/core Module in order to fix the compatibility issue with the latest released version 10.0.3.
This only changes the internal implementation of the library and how it extracts the properties from the Module. This can be improved further in the future by renaming the properties of the lib as well to match NestJS names for consistency.

@flamewow flamewow merged commit 2329097 into flamewow:main Jun 28, 2023
@flamewow
Copy link
Owner

Thanks for the PR @Pedr0Rocha

@Pedr0Rocha Pedr0Rocha deleted the fix/nestjs-10-compatibility branch June 29, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants