Fix hang caused by no Notifications service registered in DBus #4357
+48
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you please remove the translation file updates? That will mess up the weblate backend. Can you post a picture of what this looks like for a system that lacks a notification manager? Otherwise looks ready to merge. |
Issue flameshot-org#4353 Add a check when looking up the `org.freedesktop.Notifications` service to see if the it actually exists before trying to fetch it Add a check on QDBus service lookup in screengrabber freedesktop
samwcoulter
force-pushed
the
fix-hang-with-no-notification-service
branch
from
3888b01 to
46de348
Compare
Contributor
Author
|
@borgmanJeremy , amended the commit to remove the translation file changes. On a system with no notification manager, no desktop notifications will appear even if the desktop notification option is enabled. If you'd like I can add a warning log if that is the case. Here is a screenshot of my desktop immediately after taking a screenshot. No notification appears: |
Collaborator
|
Awesome thank you! As soon as this CI finishes ill merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4353
Add a check when looking up the
org.freedesktop.Notificationsservice to see if the it actually exists before trying to fetch itAdd a check on QDBus service lookup in screengrabber freedesktop