Add support for timeline-scope property #244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesodland
force-pushed
the
fix-timeline-scope
branch
from
a15032f to
ea92b1c
Compare
johannesodland
force-pushed
the
fix-timeline-scope
branch
from
ea92b1c to
cbd416b
Compare
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding initial support for the
timeline-scopeproperty, without support for the full cascade order. (Previous implementation did not support the cascade order either).This PR consists of three separate parts that were necessary to make the tests pass:
timeline-scopeproperty, and finding the referenced timeline in the timeline scope subtree