Skip to content

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jul 10, 2025

Disables testDeepUpdatesWork and testServerIncrementOverflowAndTypeCoercion in FData.m due to flakiness.

Comments updated to include TODO.

Ref: #15103

Tests pass locally with the RTDB emulator running. Not sure what's going on when running on CI.

Disables testDeepUpdatesWork and testServerIncrementOverflowAndTypeCoercion
in FData.m due to flakiness.

Comments updated to include TODO.

Ref: #15103
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@ncooke3 ncooke3 changed the title Fix: Disable flaky integration tests [Infra] Disable flaky integration tests Jul 10, 2025
@ncooke3 ncooke3 requested a review from andrewheard July 10, 2025 18:19
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ncooke3 ncooke3 requested a review from daymxn July 10, 2025 18:29
@ncooke3
Copy link
Member Author

ncooke3 commented Jul 10, 2025

Screenshot 2025-07-10 at 2 30 55 PM

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry I missed this.

@ncooke3 ncooke3 merged commit fcfc321 into main Jul 11, 2025
58 checks passed
@ncooke3 ncooke3 deleted the fix/disable-flaky-tests branch July 11, 2025 15:15
@firebase firebase locked and limited conversation to collaborators Aug 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants