Skip to content

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Apr 10, 2025

Server does not include null values into the query results when calling on isNotEqualTo or notIn filters. SDK should be consistent with it.

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@milaGGL milaGGL changed the title fix: remove null value inclusion from != and not-in filter results fix: remove null value inclusion from isNotEqualTo and notIn filter results Apr 10, 2025
@milaGGL milaGGL merged commit 6cb554b into main Apr 10, 2025
34 checks passed
@milaGGL milaGGL deleted the mila/fix-incorrect-null-value-inclusion branch April 10, 2025 21:26
@firebase firebase locked and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants