Fix aggregates field in View::get_config
#3053
Merged
+198
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Stein <[email protected]>
texodus
force-pushed
the
fix-aggregates-config
branch
from
3814fc9 to
dd2edde
Compare
Signed-off-by: Andrew Stein <[email protected]>
texodus
force-pushed
the
fix-aggregates-config
branch
from
c6b2c40 to
9a74808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
View::get_configmethod, which has been neglecting to output theaggregatesfield correctly since version3.0. This bug only affected this specific method - e.g.,HTMLPerspectiveVIewerElement::savedoes not show similar issues, which is why this bug went undetected for so long.Also: tests.