Skip to content

Conversation

texodus
Copy link
Member

@texodus texodus commented Jun 8, 2025

This PR adds a new UX for capturing the error details on hover over the error status icon. Additionally, the perspective_js::ApiError error type has been upgraded to thiserror derived version, in order to support the new UX features:

  • Instances of duplicated stack trace inlining have been removed.
  • String -> Rich error type -> String -> Rich error type -> ... conversions flattened to use ApiError everywhere.
  • Better stacktraces (in debug builds), better error messages with categories overall.
  • UI is no longer borked nor does it auto-reset (though dismissing the dialog will reset the viewer).
  • Rust API has changed to take ClientError/ApiError for Client::on_error callbacks, which is an API breaking change (though this type implements Display also).
Screenshot 2025-06-08 at 6 26 19 PM

@texodus texodus added enhancement Feature requests or improvements breaking labels Jun 8, 2025
@texodus texodus force-pushed the new-error-ux branch 3 times, most recently from f098de8 to 7296b5a Compare June 9, 2025 00:26
Signed-off-by: Andrew Stein <[email protected]>
@texodus texodus merged commit f828194 into master Jun 9, 2025
14 checks passed
@texodus texodus deleted the new-error-ux branch June 9, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant