Skip to content

Fix link error in emscripten wheel #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Fix link error in emscripten wheel #2726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/perspective/src/cpp/vendor/arrow_single_threaded_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,8 +998,8 @@ namespace csv {

Result<std::shared_ptr<TableReader>>
TableReader::Make(
const io::IOContext& io_context,
const std::shared_ptr<io::InputStream>& input,
const io::IOContext io_context,
const std::shared_ptr<io::InputStream> input,
const ReadOptions& read_options,
const ParseOptions& parse_options,
const ConvertOptions& convert_options
Expand Down
2 changes: 1 addition & 1 deletion cpp/perspective/src/include/perspective/vendor/arrow_single_threaded_reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ namespace csv {

/// Create a TableReader instance
static Result<std::shared_ptr<TableReader>>
Make(const io::IOContext& io_context, const std::shared_ptr<io::InputStream>& input, const ReadOptions&, const ParseOptions&, const ConvertOptions&);
Make(io::IOContext io_context, std::shared_ptr<io::InputStream> input, const ReadOptions&, const ParseOptions&, const ConvertOptions&);

ARROW_DEPRECATED(
"Use MemoryPool-less variant (the IOContext holds a pool already)"
Expand Down
3 changes: 0 additions & 3 deletions packages/perspective-jupyterlab/test/jupyter/widget.spec.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,15 +167,12 @@ describe_jupyter(
let edit_mode = await getEditMode(viewer);
expect(edit_mode).toEqual("READ_ONLY");

console.error("Fuck1");
await add_and_execute_cell(
page,
'w.plugin_config = {"edit_mode": "EDIT"}'
);

console.error("Fuck2");
edit_mode = await getEditMode(viewer);
console.error("Fuck3");
expect(edit_mode).toEqual("EDIT");
}
);
Expand Down
1 change: 0 additions & 1 deletion rust/perspective-server/build/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ fn main() -> Result<(), std::io::Error> {

std::fs::write("docs/lib_gen.md", markdown.as_ref())?;
if std::option_env!("PSP_DISABLE_CPP").is_none() {
println!("cargo:warning=MESSAGE FUCKED");
if let Some(artifact_dir) = psp::cmake_build()? {
psp::cmake_link_deps(&artifact_dir)?;
psp::cxx_bridge_build();
Expand Down
Loading