Added Java Implementation for FDC3 appDirectory #1620

amanjmd · 2025-06-23T17:30:07Z

Describe your change

#563

This PR provides a java implementation for FDC3 API .

Related Issue

Contributor License Agreement

I acknowledge that a contributor license agreement is required and that I have one in place or will seek to put one in place ASAP.

Review Checklist

netlify · 2025-06-23T17:30:12Z

✅ Deploy Preview for fdc3 ready!

Name	Link
🔨 Latest commit	`d3137d6`
🔍 Latest deploy log	https://app.netlify.com/projects/fdc3/deploys/68d1a44763f75a000888e321
😎 Deploy Preview	https://deploy-preview-1620.preview-fdc3.finos.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

linux-foundation-easycla · 2025-06-23T17:30:14Z

The committers listed above are authorized under a signed CLA.

✅ login: amanjmd / name: Aman Kapoor (7d6ae25, 3d90be5, ea4aece, 34049c6, d3137d6)

psmulovics · 2025-06-23T17:39:34Z

Have you considered maintaining this as a separate project from the TS implementation? Like how fdc3-dotnet is separate from the TS

amanjmd · 2025-06-23T17:55:40Z

Hi @psmulovics ,

This is a reference implementation of the FDC Open API specifications using Java and springboot . This was one of the use case of the citi-hackathon.

As part of this PR I have created a separate directory to house the Java implementation. It was suggested by @kriswest in the below comment to add the implementation to toolbox directory .
comment

Do let me know in case we need to place somewhere else.

amanjmd · 2025-07-08T18:29:28Z

Hi @kriswest let me know if we could discuss on merging the PR for the Java Implementation.

Copilot

Pull Request Overview

This PR introduces a full Java-based implementation of the FDC3 Application Directory API, including data loading, security, schema, and generated model classes.

Adds a V2ApplicationReader interface with a JSON-backed implementation and factory.
Introduces JWT‐based authentication via an interceptor and a simple user management service.
Supplies resource files (local.v2.json, user_db.json), application properties, OpenAPI schema, and generated model classes.

Reviewed Changes

Copilot reviewed 52 out of 52 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/main/resources/application.properties	Sets application name, JSON path, security credentials, reader type
src/main/resources/user_db.json	Sample user database
src/main/resources/local.v2.json	Sample application directory data
src/main/resources/app-directory-schema-2.0.yml	OpenAPI spec for the App Directory API
src/main/java/com/fdc/appd/service/V2ApplicationReader.java	Defines the service interface for v2 readers
src/main/java/com/fdc/appd/service/V2ApplicationJsonReaderImpl.java	Implements JSON-based reader with lazy loading
src/main/java/com/fdc/appd/service/ApplicationReaderFactory.java	Factory selects reader implementation based on configuration
src/main/java/com/fdc/appd/security/UserManagementServiceImpl.java	Loads and validates users from JSON
src/main/java/com/fdc/appd/security/JwtUtil.java	Utility for signing and validating JWTs
src/main/java/com/fdc/appd/security/JwtAuthInterceptor.java	Intercepts HTTP requests to enforce JWT authentication
src/main/java/com/fdc/appd/model/**.java	Generated model classes from the OpenAPI schema

Comments suppressed due to low confidence (2)

toolbox/fdc3-appd-java/fdc3-app-directory-java/src/main/resources/application.properties:5

The property key is malformed: it should use '=' instead of '-'. Change to spring.security.user.password=sa.

spring.security.user.password-sa

toolbox/fdc3-appd-java/fdc3-app-directory-java/src/main/java/com/fdc/appd/service/V2ApplicationJsonReaderImpl.java:38

Potential race condition: multiple threads could initialize allApplications concurrently. Consider synchronizing the initialization or using a thread-safe lazy holder.

        if(Objects.isNull(allApplications))

Copilot · 2025-07-09T13:16:03Z

...ppd-java/fdc3-app-directory-java/src/main/java/com/fdc/appd/service/V2ApplicationReader.java

+    /**
+     *
+     * @param appId
+     * @return com.fdc.appd.model.Applciation


Typo in the return Javadoc: 'Applciation' should be corrected to 'Application'.

Suggested change

* @return com.fdc.appd.model.Applciation

* @return com.fdc.appd.model.Application

HI @kriswest ,

I have resolved the copilot comment for this file

...ava/fdc3-app-directory-java/src/main/java/com/fdc/appd/service/ApplicationReaderFactory.java

Copilot · 2025-07-09T13:16:04Z

...a/fdc3-app-directory-java/src/main/java/com/fdc/appd/security/UserManagementServiceImpl.java

+        try {
+            userDb= objectMapper.readValue(resource.getInputStream(), new TypeReference<HashMap<String,String>>() {});
+        } catch (IOException e) {
+            System.out.println("Error in loading Users DB");


[nitpick] Avoid using System.out.println for error handling. Consider using a logger at ERROR level and rethrow or handle the exception properly.

Hi @kriswest

I have done the required changes for this comment.

Copilot · 2025-07-09T13:16:04Z

toolbox/fdc3-appd-java/fdc3-app-directory-java/src/main/java/com/fdc/appd/security/JwtUtil.java

+
+            return Optional.of(claims);
+        } catch (Exception e) {
+            System.out.println(e);


[nitpick] Printing the exception to stdout is not ideal. Use a logger to record the stack trace and avoid exposing internal errors to standard output.

Suggested change

System.out.println(e);

LOGGER.log(Level.SEVERE, "Exception occurred while validating token", e);

amanjmd · 2025-08-13T10:08:15Z

HI @kriswest I have mage the required changes as per the copilot comments .
Let me know if any further changes are required.

robmoffat

In general this looks pretty solid, but just needs some tests.

I think rather than add this code here, though, we should add to https://github.com/finos-labs/fdc3-java-api and complete the Java support there.

robmoffat · 2025-09-10T11:44:14Z

...pp-directory-java/src/test/java/com/fdc/appd/Fdc3AppDirectoryJavaSpringApplicationTests.java

+import org.springframework.boot.test.context.SpringBootTest;
+
+@SpringBootTest
+class Fdc3AppDirectoryJavaSpringApplicationTests {


It would be nice to see some tests here for all the endpoints that have been created, perhaps this can be done with an example AppD file?

Hi @robmoffat ,

I have added the test cases in this PR and also are part of the below PR on the suggested repository .

finos-labs/fdc3-java-api#6

Kindly let me know in case any further edits are required .

Added Java Implementation for FDC3 API

7d6ae25

amanjmd requested a review from a team as a code owner June 23, 2025 17:30

amanjmd mentioned this pull request Jun 23, 2025

Create an AppD reference implementation #563

Open

kriswest mentioned this pull request Jun 25, 2025

App directory endpoints require hosting and configuration #1622

Closed

bingenito requested a review from Copilot July 9, 2025 13:13

Copilot AI reviewed Jul 9, 2025

View reviewed changes

kriswest changed the title ~~Added Java Implementation for FDC3 API~~ Added Java Implementation for FDC3 appDirectory Jul 18, 2025

amanjmd added 3 commits August 13, 2025 14:28

ApplicationReaderFactory.java :Resolved copilot comment

34049c6

V2ApplicationReader.java:Resolved copilot comments

ea4aece

Resolved copilot comments

3d90be5

robmoffat previously approved these changes Sep 10, 2025

View reviewed changes

Added tests

d3137d6

amanjmd dismissed robmoffat’s stale review via d3137d6 September 22, 2025 19:32

	* @return com.fdc.appd.model.Applciation
	* @return com.fdc.appd.model.Application

	System.out.println(e);
	LOGGER.log(Level.SEVERE, "Exception occurred while validating token", e);

Added Java Implementation for FDC3 appDirectory #1620

Are you sure you want to change the base?

Added Java Implementation for FDC3 appDirectory #1620

Uh oh!

Conversation

amanjmd commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change

Related Issue

Contributor License Agreement

Review Checklist

Uh oh!

netlify bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fdc3 ready!

Uh oh!

linux-foundation-easycla bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

psmulovics commented Jun 23, 2025

Uh oh!

amanjmd commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amanjmd commented Jul 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

amanjmd Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

amanjmd Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

amanjmd commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robmoffat left a comment

Choose a reason for hiding this comment

Uh oh!

robmoffat Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

amanjmd Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amanjmd commented Jun 23, 2025 •

edited

Loading

netlify bot commented Jun 23, 2025 •

edited

Loading

linux-foundation-easycla bot commented Jun 23, 2025 •

edited

Loading

amanjmd commented Jun 23, 2025 •

edited

Loading

amanjmd commented Aug 13, 2025 •

edited

Loading

amanjmd Sep 22, 2025 •

edited

Loading