placeholder do not escape double quotes

[yuriyoung]

Package

filament/filament

Package Version

v3.3.34

Laravel Version

v12.2.0

Livewire Version

v3.6.4

PHP Version

PHP 8.4

Problem description

Expected behavior

Present the raw string.

Steps to reproduce

public function form(Form $form): Form
    {
        return $form
            ->schema([

                Forms\Components\TextInput::make('array')
                    ->columnSpanFull()
                    ->hint('TextInput')
                    ->placeholder('Data in Array format: ["key" => "value", "foo" => "bar"]'),

                Forms\Components\Textarea::make('Json')
                    ->columnSpanFull()
                    ->hint('Textarea')
                    ->helperText('No escaped double quotes but single quotes are fine.')
                    ->placeholder('Meta data in JSON format: {\'key\': \'value\', \"foo\": \"bar\"}'),

                Forms\Components\RichEditor::make('description')
                    ->columnSpanFull()
                    ->hint('RichEditor')
                    ->helperText('Double quotes are fine.')
                    ->placeholder('Meta data in JSON format: {"key": "value", "foo": \"bar\"}'),
            ]);
    }

Reproduction repository (issue will be closed if this is not valid)

https://github.com/bakuon/filament-app

Relevant log output

[sunnybherwani]

@danharrin
I'm reviewing this issue and I tried to find a patch for this bug:

Package
filament/forms

File Path:
[filament forms package]/src/Components/Concerns/HasPlaceholder.php

Change line no. 13

$this->placeholder = $placeholder;
to

$this->placeholder = is_string($placeholder) == true ? htmlspecialchars($placeholder, ENT_QUOTES, 'UTF-8') : $placeholder;

and it seems working fine.

Wondering 🤔 that something considered as a valid solution?

PS: Want to contribute to open source.

[danharrin]

This doesn't seem right, sorry. It is probably an issue on the output side instead of the setter method.

[sunnybherwani]

Got you.
I'll try to get few other details with suggestions.