[SECURITY FIX] Bump undici to 5.29.0 #276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ptomas-figma @tomduncalf-figma I know the contributing guidelines say you're not accepting PRs, but this is a security issue. Without this fix, projects including figma/code-connect are potentially vulnerable to the undici DoS issue described in the issue linked above. |
olivier-thatch
changed the title
|
Hey @olivier-thatch, thanks for the contribution! We can't accept PRs on the public repo due to our release process but I've merged your change on our side which'll be going out soon in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undici 5.28.x has a known security vulnerability: nodejs/undici#3895
The issue was fixed in 5.29.0 by nodejs/undici#4088