-
-
Notifications
You must be signed in to change notification settings - Fork 64
Include htmx.org and hyperscript.org as part of javascript bundle. #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include htmx.org and hyperscript.org as part of javascript bundle. #430
Conversation
Sorry, closed this a bit abruptly, I saw your discussion topic after |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 239 239
Lines 8099 8099
=======================================
Hits 7419 7419
Misses 680 680 ☔ View full report in Codecov by Sentry. |
No worries 😄 For readers of the thread, link to the discussion article: |
So, I agree with the objective of the PR and I think it would be a great addition. However, just adding htmx and hyperscript as JS dependency is not sufficient here: we need to bundle it with Rollup (like we do for CSS and the code editor module for example) and include it in our template header. |
Can you please point me to the file containing the template header? |
@frankie567 check out the new changes that bundle htmx and hyperscript with Rollup. Big shout out to @nathanbowman |
Thank you @i-am-mike-davis 👍 I've tweaked the setup so everything is output and minified in a single file. |
The Administration UI requires htmx.org and hyperscript.org from unpkg.com. Without these packages, all htmx functions on the UI break (e.g. adding redirect URIs). This commit attempts to include these packages as part of the javascript bundle as described in the Hypermedia Systems book: https://hypermedia.systems/extending-html-as-hypermedia/
86a009c
to
9eab375
Compare
@all-contributors add @i-am-mike-davis for code |
I've put up a pull request to add @i-am-mike-davis! 🎉 |
The Administration UI requires htmx.org and hyperscript.org
from unpkg.com. Without these packages, all htmx functions
on the UI break (e.g. adding redirect URIs). This commit attempts
to include these packages as part of the javascript bundle as
described in the Hypermedia Systems book:
https://hypermedia.systems/extending-html-as-hypermedia/