Skip to content

Conversation

i-am-mike-davis
Copy link
Contributor

@i-am-mike-davis i-am-mike-davis commented Aug 27, 2024

The Administration UI requires htmx.org and hyperscript.org
from unpkg.com. Without these packages, all htmx functions
on the UI break (e.g. adding redirect URIs). This commit attempts
to include these packages as part of the javascript bundle as
described in the Hypermedia Systems book:
https://hypermedia.systems/extending-html-as-hypermedia/

@frankie567
Copy link
Member

frankie567 commented Aug 27, 2024

This is working right now in production, I don't see the point of those changes.

Sorry, closed this a bit abruptly, I saw your discussion topic after ☺️ That might be indeed interesting, I'll have a closer look

@frankie567 frankie567 closed this Aug 27, 2024
@frankie567 frankie567 reopened this Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (5a3c28d) to head (9eab375).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files         239      239           
  Lines        8099     8099           
=======================================
  Hits         7419     7419           
  Misses        680      680           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@i-am-mike-davis
Copy link
Contributor Author

This is working right now in production, I don't see the point of those changes.

Sorry, closed this a bit abruptly, I saw your discussion topic after ☺️ That might be indeed interesting, I'll have a closer look

No worries 😄

For readers of the thread, link to the discussion article:
https://github.com/orgs/fief-dev/discussions/431

@frankie567
Copy link
Member

So, I agree with the objective of the PR and I think it would be a great addition.

However, just adding htmx and hyperscript as JS dependency is not sufficient here: we need to bundle it with Rollup (like we do for CSS and the code editor module for example) and include it in our template header.

@i-am-mike-davis
Copy link
Contributor Author

So, I agree with the objective of the PR and I think it would be a great addition.

However, just adding htmx and hyperscript as JS dependency is not sufficient here: we need to bundle it with Rollup (like we do for CSS and the code editor module for example) and include it in our template header.

Can you please point me to the file containing the template header?

@i-am-mike-davis
Copy link
Contributor Author

i-am-mike-davis commented Sep 12, 2024

@frankie567 check out the new changes that bundle htmx and hyperscript with Rollup. Big shout out to @nathanbowman

@frankie567
Copy link
Member

Thank you @i-am-mike-davis 👍 I've tweaked the setup so everything is output and minified in a single file.

i-am-mike-davis and others added 4 commits October 5, 2024 08:38
The Administration UI requires htmx.org and hyperscript.org
from unpkg.com. Without these packages, all htmx functions
on the UI break (e.g. adding redirect URIs). This commit attempts
to include these packages as part of the javascript bundle as
described in the Hypermedia Systems book:
https://hypermedia.systems/extending-html-as-hypermedia/
@frankie567 frankie567 force-pushed the codespace-vigilant-acorn-5gqgjgqxj4x737rp9 branch from 86a009c to 9eab375 Compare October 5, 2024 06:42
@frankie567 frankie567 merged commit 1838b51 into fief-dev:main Oct 5, 2024
9 of 10 checks passed
@frankie567
Copy link
Member

@all-contributors add @i-am-mike-davis for code

Copy link
Contributor

@frankie567

I've put up a pull request to add @i-am-mike-davis! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants