-
Notifications
You must be signed in to change notification settings - Fork 107
Closed
Description
Describe the bug
The Pipeline seems to be broken e.g.: https://github.com/fi3ework/vite-plugin-checker/actions/runs/5624436053/job/15241257246?pr=263
I had a look into it:
- node 18 test is generating a difference in the snapshot
- node 20: is running into a pnpm error which is resolved in v8.3.1
- node 16 on MacOS is generating a difference in the snapshot
My suggestion would be:
- Fix the snapshot test or remove it for node 18, maybe by creating a custom env flag for it
- Update pnpm to the latest version - I can provide a PR for that @fi3ework
- Fix the snapshot for MacOS or even consider dropping the test for now
I would also suggest having the pipeline to run through correctly otherwise it would be possible to overlook errors.
Reproduction
Open PR and let the pipeline run.
Expected behavior
Pipeline should run successfully with all tests.
System Info
Not needed.
Additional context
No response
Validations
- Read the docs.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
maico910
Metadata
Metadata
Assignees
Labels
No labels