Check patronic config and only update if neccessary #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3f57b1c.
majst01
reviewed
Sep 2, 2022
controllers/postgres_controller.go
Outdated
|
|
||
| defer resp.Body.Close() | ||
|
|
||
| body, err := ioutil.ReadAll(resp.Body) |
Gerrit91
reviewed
Feb 2, 2023
Comment on lines
+247
to
+249
| viper.SetDefault(replicationChangeRequeueTimeFlg, 10) | ||
| replicationChangeRequeueTimeInSeconds = viper.GetInt(replicationChangeRequeueTimeFlg) | ||
| replicationChangeRequeueDuration := time.Duration(replicationChangeRequeueTimeInSeconds) * time.Second |
Contributor
There was a problem hiding this comment.
There is also a Duration type for viper arguments, which simplifies handling the flag.
| httpClient := &http.Client{} | ||
| url := "http://" + podIP + ":" + podPort + "/" + path | ||
|
|
||
| req, err := http.NewRequestWithContext(ctx, "GET", url, nil) |
|
|
||
| body, err := io.ReadAll(resp.Body) | ||
| if err != nil { | ||
| r.Log.Info("could not read body") |
Contributor
There was a problem hiding this comment.
Should also use Log.Error and wrap the error.
| var jsonResp PatroniConfig | ||
| err = json.Unmarshal(body, &jsonResp) | ||
| if err != nil { | ||
| r.Log.Info("could not parse config") |
Contributor
There was a problem hiding this comment.
Should also use Log.Error and wrap the error.
Gerrit91
reviewed
Feb 2, 2023
| // this is done down here to make sure the rest of the resource updates were performed | ||
| if patroniConfigChangeErr != nil { | ||
| log.Info("Requeueing after modifying patroni replication config failed") | ||
| return ctrl.Result{Requeue: true, RequeueAfter: 10 * time.Second}, patroniConfigChangeErr |
Contributor
There was a problem hiding this comment.
Exponential backoff might be better on Patroni API unavailability
Collaborator
Author
|
Resolve conflicts and merge! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.