Add support for clojure 1.9 #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making a note that this PR will remove support for Clojure 1.8 and earlier. |
|
Or bump clojure.core.incubator to 0.1.4 where the seqable? function is correctly deprecated and the exclude is properly done so we don't get any warning? |
|
I am getting the warnings with Clojars version of Clostache 1.4.0, while using Downloading: de/ubercode/clostache/clostache/1.4.0/clostache-1.4.0.pom from clojars
Downloading: org/clojure/core.incubator/0.1.2/core.incubator-0.1.2.pom from central
....
....
....
WARNING: seqable? already refers to: #'clojure.core/seqable? in namespace: clojure.core.incubator, being replaced by: #'clojure.core.incubator/seqable?
WARNING: seqable? already refers to: #'clojure.core/seqable? in namespace: clostache.parser, being replaced by: #'clojure.core.incubator/seqable?
I would appreciate if someone could publish an updated version of the fix that addresses the warnings, to Clojars. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed the .incubator so that clostache can be used with clojure 1.9