-
Notifications
You must be signed in to change notification settings - Fork 1.2k
adding fullscreenNavigationUI option; fix #482 #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding fullscreenNavigationUI option; fix #482 #483
Conversation
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 75.93% 75.80% -0.13%
==========================================
Files 8 8
Lines 1421 1422 +1
==========================================
- Hits 1079 1078 -1
- Misses 342 344 +2
Continue to review full report at Codecov.
|
Please do not push any automatically generated files, such as any files in the |
Your idea is good, but your solution may be a bit one-sided. |
dac1cd4
to
ae69808
Compare
Summary
On devices with soft UI buttons (Android/Amazon Fire, etc), when in fullscreen mode, some browsers still renders the soft UI buttons at the bottom of the screen, taking away from the "fullscreen" experience.
This PR adds a new Viewer option
fullscreenNavigationUI
, to modify that soft UI button display behavior per Mozilla web spec.Fixes issue #482.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:

Before:
After:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
I realize the contributing guidelines ask for a reproducible example.
Although, this particular issues requires a particular device with soft UI buttons and is reproducible via master branch.
Hopefully, that explanation is sufficient and this PR will be allowed.
Thanks!