Skip to content

Do less work when assigning bins by ID #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Do less work when assigning bins by ID #321

wants to merge 4 commits into from

Conversation

e-n-f
Copy link
Collaborator

@e-n-f e-n-f commented Feb 12, 2025 •
edited
Loading

This PR makes bin assignment by ID faster by skipping the spatial loop entirely. It also makes sorting the features of an mvt_layer faster by sorting pointers instead of feature objects.

@e-n-f e-n-f marked this pull request as ready for review February 12, 2025 21:06
@e-n-f e-n-f mentioned this pull request May 22, 2025
Draft
@e-n-f e-n-f force-pushed the faster-bin-assign branch from 53505a0 to 8780064 Compare July 10, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arredond arredond Awaiting requested review from arredond arredond is a code owner

@dnomadb dnomadb Awaiting requested review from dnomadb dnomadb is a code owner

@ChrisLoer ChrisLoer Awaiting requested review from ChrisLoer ChrisLoer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@e-n-f