Skip to content

Conversation

sethstoudenmier
Copy link
Contributor

@sethstoudenmier sethstoudenmier commented Aug 8, 2025

Description:

New endpoint that returns the Program Activities under a Federal Account.

Technical Details:

This creates the initial files needed to support additional Federal Account endpoints following a similar pattern as the Agency V2 endpoints. The base class is very barebones right now, but will grow as we implement more endpoints.

Requirements for PR Merge:

  1. Unit & integration tests updated
  2. API documentation updated (examples listed below)
    1. API Contracts
    2. API UI
    3. Comments
  3. Data validation completed (examples listed below)
    1. Does this work well with the current frontend? Or is the frontend aware of a needed change?
    2. Is performance impacted in the changes (e.g., API, pipeline, downloads, etc.)?
    3. Is the expected data returned with the expected format?
  4. N/A Appropriate Operations ticket(s) created
  5. Jira Ticket(s)
    1. DEV-13054

Explain N/A in above checklist:

Copy link
Contributor

@zachflanders-frb zachflanders-frb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I am curious about the decision to use the django ORM vs elasticsearch for this endpoint.

@sethstoudenmier
Copy link
Contributor Author

Looks good. I am curious about the decision to use the django ORM vs elasticsearch for this endpoint.

@zachflanders-frb We don't currently capture any File B data in Elasticsearch

@sethstoudenmier sethstoudenmier merged commit f1d35b0 into qat Aug 13, 2025
13 checks passed
@sethstoudenmier sethstoudenmier deleted the ftr/dev-13054-list-fed-acct-prog-activity branch August 13, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants