Skip to content

Ftr/dev 13014 add park to program activity #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 11, 2025

Conversation

loreleitrimberger
Copy link
Contributor

@loreleitrimberger loreleitrimberger commented Aug 7, 2025

Description:

Add PARK to tas program activities by returning the PARK if there's a park otherwise the PAC/PAN if that exists

Added an identifier, type, to clarify if the PARK or PAC/PAN is being returned

Technical Details:

Requirements for PR Merge:

  1. Unit & integration tests updated
  2. API documentation updated (examples listed below)
    1. API Contracts
    2. API UI
    3. Comments
  3. N/A Data validation completed (examples listed below)
    1. Does this work well with the current frontend? Or is the frontend aware of a needed change?
    2. Is performance impacted in the changes (e.g., API, pipeline, downloads, etc.)?
    3. Is the expected data returned with the expected format?
  4. N/A Appropriate Operations ticket(s) created
  5. Jira Ticket(s)
    1. DEV-13014

Explain N/A in above checklist:

Copy link
Contributor

@sethstoudenmier sethstoudenmier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change on the API contract

@@ -93,6 +94,7 @@ Returns a list of Program Activities for the specified Treasury Account Symbol (
+ `name` (required, string)
+ `obligated_amount` (required, number)
+ `gross_outlay_amount` (required, number)
+ `type` (required, string)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this to be an enum[string] and then have it show the possible values of "PARK" or "PAC/PAN"?

@loreleitrimberger loreleitrimberger merged commit 0a4f15f into qat Aug 11, 2025
35 of 37 checks passed
@loreleitrimberger loreleitrimberger deleted the ftr/dev-13014-add-park-to-program-activity branch August 11, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants