Skip to content

[DEV-12966] Add pagination to spending_by_subaward_grouped endpoint #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

aguest-kc
Copy link
Contributor

@aguest-kc aguest-kc commented Aug 5, 2025

Description:

Updated the /api/v2/search/spending_by_subaward_grouped/ endpoint to correctly paginate results and to sort results within Elasticsearch instead of in Python.

Technical Details:

I added an ad-hoc agg key that combines the Award ID and Award unique key fields together to prevent creating sub-bucket aggregations which are hard to sort on.

Requirements for PR Merge:

  1. Unit & integration tests updated
  2. Data validation completed (examples listed below)
    1. Does this work well with the current frontend? Or is the frontend aware of a needed change?
    2. Is performance impacted in the changes (e.g., API, pipeline, downloads, etc.)?
    3. Is the expected data returned with the expected format?
  3. Jira Ticket(s)
    1. DEV-12966

Explain N/A in above checklist:

  1. API documentation updated (examples listed below)
    No API contracts changes are necessary.

  2. Appropriate Operations ticket(s) created
    No operations tickets are required for this change.

@aguest-kc aguest-kc added the do not merge [PR] shouldn't be merged label Aug 5, 2025
@aguest-kc aguest-kc closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge [PR] shouldn't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant