Refresh and side tag #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to remove the hardcoded Rawhide version in code as well as keep the `rawhide` branch stay permanently. It also simplifies the code a bit, because there do not need to be added the `f` prefixes on various places.
This is in preparation to reaplace `tar` by `git archive` command, which does not correctly understadn `.tgz` extension and produces plain unarchived tarballs.
Switched from creating a tarball by `tar` to utilizing Git's `archive` command for better reproducibility and robustness.
This is not needed anymore, because the version is specified for `git archive` command.
Added a conditional check to verify the test suite availability before entering the files. This prevents creating test suite archives from wrong sources.
This prevents possible side effect, such as creating test tarball from wrong sources.
This reflects components as of Rails 8.0
Better to use this official tool whenever possible then hand crafted `sed` commands.
Ensure that existing changelog entries are recycled if they match an old version number, maintaining the proper component naming.
Analyze content of the .spec file to get not just `-test` tarballs, but also all other sources. This assumes that: 1. the line above `Source` tag contains information about call to `git archive` command 2. the line contains relevant version information
Better to fetch gems together with outher sources instead of fetching them as part of updating .spec file.
Previously, the epoch was not correctly detected and therefore possible duplicates could slip through.
Exit the directory when shortcutting the loop.
Try to fetch BZ ticket number for rubygem-railties, created by the-new-hotness, and append it into changelog(s).
Side-tags are currently encouraged for multi package updates. This helps to reduce breakage in Rawhide due to broken dependencies. It also allows to set [1] `bootstrap` macro [2] for buildroot and therefore no additional commits are needed for bootstrapping. [1]: https://docs.fedoraproject.org/en-US/package-maintainers/Package_Update_Guide/#_using_macros_in_a_side_tag [2]: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bootstrapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lot of updates. But the main benefit of this PR is that now, the side-tag together with
bootstrapmacro is used for build. This reduces the amount of breakage as well as number of commits.@jprokop could you please take a brief look? I have used this to build RoR 8.0.3, so it can't be terribly wrong 😇