Wait for rpmdev-setuptree to exit. #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@decathorpe I'd like to publish a version to support py3.10, and ship a handful of fixes with that. If you have time to glance at a few of these, that'd be great. (I'll ping you on the others.) If there are no objections, I'll merge these next weekend. |
|
Looks good to me. Though the whole thing could be replaced with a higher level subprocess.run call instead. |
Member
Author
|
Run was added in 3.5, according to the docs. At some point, we'll raise the minimum version, but right now it seems like there are still a lot of EPEL users, so I keep putting that off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266