<iframe> tag must have closing tag #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If closing tag is missing, some undefined behaviors will provides test failure.
|
Thank you for the contribution. I've found only one small issue. |
|
@frenzymadness |
Newer lxml like lxml 6 encodes and keeps control characters as neutralized form. It eliminates some evil attempts. Adds fixup to expected result text to pass doctest.
https://github.com/lxml/lxml/blob/lxml-6.0.0/CHANGES.txt#L59 > * Support for Python < 3.8 was removed. Drop py36 from test target list.
qykth-git
force-pushed
the
iframe-test-fix
branch
from
cbcd16f to
d5f935c
Compare
|
@frenzymadness |
|
Thank you! You are reading my mind. We've just discussed that we no longer need to test lxml_html_clean with Python 3.6. Thank you also for the other fixes. |
This reverts commit 13447fd.
|
@frenzymadness |
|
I'm going to merge this and release it. Thanks a lot! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If closing tag is missing, some undefined behaviors will provides test failure.
This PR fixes #24 .