-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/1575 - Security Consent Versioning #1733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1575 - Security Consent Versioning #1733
Conversation
| migrations.AddField( | ||
| model_name='user', | ||
| name='security_consent_version', | ||
| field=models.IntegerField(blank=True, null=True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason Integer feels wrong here, like if we wanted to have partial versions 1.1 for small changes. But honestly just using whole numbers is perfectly fine, and more personal preference than anything.
toddlees
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a line that unsets the consent_for_one_year when the value is set to false in the payload. This gives us the behavior of a user not checking the box when they review a new version. They won't get to skip it until they check the box
Unfortunately I merged the App pr before pushing the App change. I made a new pr for that patch
|



Ticket link: here
Related PRs: App