Skip to content

Conversation

@Elaine-Krauss-TCG
Copy link
Contributor

@Elaine-Krauss-TCG Elaine-Krauss-TCG commented Oct 3, 2025

Ticket link: here

Related PRs: App

@Elaine-Krauss-TCG Elaine-Krauss-TCG changed the title [WIP] Feature/1575 - Security Consent Versioning Feature/1575 - Security Consent Versioning Oct 10, 2025
migrations.AddField(
model_name='user',
name='security_consent_version',
field=models.IntegerField(blank=True, null=True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason Integer feels wrong here, like if we wanted to have partial versions 1.1 for small changes. But honestly just using whole numbers is perfectly fine, and more personal preference than anything.

Copy link
Contributor

@toddlees toddlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a line that unsets the consent_for_one_year when the value is set to false in the payload. This gives us the behavior of a user not checking the box when they review a new version. They won't get to skip it until they check the box

Unfortunately I merged the App pr before pushing the App change. I made a new pr for that patch

@sonarqubecloud
Copy link

@toddlees toddlees merged commit 0dbbc5f into develop Oct 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants