Skip to content

fix: Column quoting in query of PostgreSQLOfflineStore.pull_all_from_table_or_query #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2025
Merged

fix: Column quoting in query of PostgreSQLOfflineStore.pull_all_from_table_or_query #5621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9e4e64
Fix column quoting issue in query in `PostgreSQLOfflineStore.pull_all…
hungnguyen94 Sep 19, 2025
1c75973
fix: failing test due to changes in expected query
hungnguyen94 Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,10 @@ def pull_all_from_table_or_query(
if created_timestamp_column:
timestamp_fields.append(created_timestamp_column)
field_string = ", ".join(
join_key_columns + feature_name_columns + timestamp_fields
_append_alias(
join_key_columns + feature_name_columns + timestamp_fields,
"paftoq_alias",
)
)

timestamp_filter = get_timestamp_filter_sql(
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/infra/offline_stores/contrib/postgres_offline_store/test_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def test_pull_all_from_table_or_query(mock_get_conn):
actual_query = retrieval_job.to_sql().strip()
logger.debug("Actual query:\n%s", actual_query)

expected_query = """SELECT key1, key2, feature1, feature2, event_published_datetime_utc
expected_query = """SELECT paftoq_alias."key1", paftoq_alias."key2", paftoq_alias."feature1", paftoq_alias."feature2", paftoq_alias."event_published_datetime_utc"
FROM offline_store_database_name.offline_store_table_name AS paftoq_alias
WHERE "event_published_datetime_utc" BETWEEN '2021-01-01 00:00:00+00:00'::timestamptz AND '2021-01-02 00:00:00+00:00'::timestamptz""" # noqa: W293

Expand Down