-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Feast Namespaces registry for client ConfigMaps availability #5599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3c5a9e
to
63dd34e
Compare
ntkathole
reviewed
Sep 11, 2025
ntkathole
reviewed
Sep 11, 2025
ntkathole
reviewed
Sep 11, 2025
infra/feast-operator/internal/controller/services/namespace_registry.go
Outdated
Show resolved
Hide resolved
ntkathole
reviewed
Sep 11, 2025
infra/feast-operator/internal/controller/services/services_types.go
Outdated
Show resolved
Hide resolved
ntkathole
reviewed
Sep 11, 2025
infra/feast-operator/internal/controller/services/namespace_registry.go
Outdated
Show resolved
Hide resolved
ntkathole
reviewed
Sep 11, 2025
infra/feast-operator/internal/controller/services/services_types.go
Outdated
Show resolved
Hide resolved
63dd34e
to
9868eda
Compare
@jyejare Please fix the formatting and rebase |
Remove the registry entry for deleted feature store instance Signed-off-by: jyejare <[email protected]>
e9c65e5
to
ab6153a
Compare
Signed-off-by: jyejare <[email protected]>
ab6153a
to
5f45a6e
Compare
@ntkathole Done. |
Signed-off-by: jyejare <[email protected]>
06d6237
to
0feba31
Compare
ntkathole
approved these changes
Sep 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! For future enhancement, it would be great if we can make it configurable and allow to define namespace explicitly in CR instance.
franciscojavierarceo
pushed a commit
that referenced
this pull request
Sep 30, 2025
# [0.54.0](v0.53.0...v0.54.0) (2025-09-30) ### Bug Fixes * Column quoting in query of `PostgreSQLOfflineStore.pull_all_from_table_or_query` ([#5621](#5621)) ([e8eae71](e8eae71)) * Correct column list polars materialization engine ([#5595](#5595)) ([39aeb0c](39aeb0c)) * Fix Go feature server entitykey serialization for version 3 ([#5622](#5622)) ([5ab18a6](5ab18a6)) * Fix hostname resolution for spark tests ([#5610](#5610)) ([8f0e22d](8f0e22d)) * Fixed filtering based on data_source for ODFVs ([#5593](#5593)) ([c3e6c56](c3e6c56)) * Fixed project_description to set in registry and UI ([#5602](#5602)) ([02c3006](02c3006)) * Fixed Registry Cache Refresh Issues ([#5604](#5604)) ([3c7a022](3c7a022)) * Fixed tls issue when running both grpc and rest servers ([#5617](#5617)) ([51c16b1](51c16b1)) * Fixed transaction handling with SQLite registry ([#5588](#5588)) ([0052754](0052754)) * Update the deprecated functions in Go feature server. ([#5632](#5632)) ([a24e06e](a24e06e)) * Updated python packages conflicting with kserve dependencies ([#5580](#5580)) ([d56baf4](d56baf4)) ### Features * Add 'featureView' in global search api result for features. ([#5626](#5626)) ([76590bf](76590bf)) * Add aggregation in OnDemandFeatureView ([#5629](#5629)) ([8715ae8](8715ae8)) * Added codeflare-sdk to requirements ([#5640](#5640)) ([51a0ee6](51a0ee6)) * Added RemoteDatasetProxy that executes Ray Data operations remotely ([7128024](7128024)) * Added support for image search ([#5577](#5577)) ([56c5910](56c5910)) * Enable ingestion without event timestamp ([#5625](#5625)) ([eb51f00](eb51f00)) * Feast dataframe phase1 ([#5611](#5611)) ([2ce4198](2ce4198)) * Feast dataframe phase2 ([#5612](#5612)) ([1d08786](1d08786)) * Feast Namespaces registry for client ConfigMaps availability ([#5599](#5599)) ([728589a](728589a)) * Support hdfs:// uris in to_remote_storage for Spark offline store ([#5635](#5635)) ([5e4b9fd](5e4b9fd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Feast Namespace Registry is a feature that automatically creates and maintains a centralized ConfigMap containing information about all Feast feature store instances deployed by the operator. This enables dashboard applications and other tools to discover and connect to Feast instances across different namespaces. This addresses:
ConfigMap Creation: The operator creates a ConfigMap in the appropriate namespace:
redhat-ods-applications
namespace (or DSCi configured namespace)feast-operator-system
namespaceAccess Control: A RoleBinding is created to allow
system:authenticated
users to read the ConfigMapAutomatic Registration and removal: When a new feature store instance is created, it automatically registers its namespace and client configuration in the ConfigMap. Also when feature store is removed it automatically removes the entry from registry.
Data Structure: The ConfigMap contains a JSON structure with namespace names as keys and lists of client configuration names as values
Usage
The namespace registry is automatically deployed/updated when any Feast feature store instance is created. No additional configuration is required.
ODH Flow Usage:
Which issue(s) this PR fixes:
This implementation addresses the following requirements from RHOAIENG-33698
Misc