fix: Bugfix and add retry logic to dynamodb as onlinestore #5476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A few weeks ago, I made PR and merge it for integrating dynamodb as online store in Golang feature server. And before applying it in my production, I run load test with locust in EKS cluster. During load testing, One bug is found and I found the one thing that I will enhance when requesting to dynamodb.
Which issue(s) this PR fixes:
I made two features in Golang feature server. the explanation for them is below.
unprocessedEntityIds
variable maintains processed entity keys. But this variable is globally defined outside feature view loop. So, if some entity keys doesn't exist inA
feature view, then delete them fromunprocessedEntityIds
. Because of this, although the entity keys exist inB
feature view, Golang server requests to dynamodb not including the entity keys. At the result, the below bug occurs nil derefrence. The stack trace is below.So, I move defining
unprocessedEntityIds
(in the new commit, I renameunprocessedEntityIdsFeatureView
variable) in feature view loop.feature_store.yaml
.Misc
@shuchu @jyejare cc. @franciscojavierarceo