chore: Update numpy #5427
Merged
chore: Update numpy #5427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkathole
force-pushed
the
upgrade_numpy
branch
4 times, most recently
from
70fec5e to
dfe82c9
Compare
Signed-off-by: ntkathole <[email protected]>
Signed-off-by: ntkathole <[email protected]>
franciscojavierarceo
approved these changes
Jun 6, 2025
| FEAST_IS_LOCAL_TEST=True \ | ||
| FEAST_LOCAL_ONLINE_CONTAINER=True \ | ||
| python -m pytest --tb=short -v -n 8 --color=yes --integration --durations=10 --timeout=1200 --timeout_method=thread --dist loadgroup \ | ||
| python -m pytest --tb=short -v -n 4 --color=yes --integration --durations=10 --timeout=1200 --timeout_method=thread --dist loadgroup \ |
There was a problem hiding this comment.
Currently with 8, runner is intermittently throwing Error: The operation was canceled. (not related to this PR, happening on all PRs) due to high memory load on node. For stability, reduced to 4.
j-wine
pushed a commit
to j-wine/feast
that referenced
this pull request
Jun 7, 2025
* chore: update numpy Signed-off-by: ntkathole <[email protected]> * chore: Reduce concurrency to save memory on runners Signed-off-by: ntkathole <[email protected]> --------- Signed-off-by: ntkathole <[email protected]> Signed-off-by: Jacob Weinhold <[email protected]>
devin-ai-integration bot
pushed a commit
to franciscojavierarceo/feast
that referenced
this pull request
Jun 9, 2025
* chore: update numpy Signed-off-by: ntkathole <[email protected]> * chore: Reduce concurrency to save memory on runners Signed-off-by: ntkathole <[email protected]> --------- Signed-off-by: ntkathole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for numpy>2.
Key points:
Which issue(s) this PR fixes:
#5074
Misc
If you're using an Intel-based Mac (not Apple Silicon) or running Python with Rosetta-translated x86_64 architecture:
You cannot install PyTorch versions 2.3.0+ via pip, as no compatible wheels are published. The last supported version is: torch==2.2.2.
To upgrade to newer versions like torch==2.7.0, you must use macOS 14+ on Apple Silicon (arm64) and run a matching arm64 Python environment.
To check your architecture:
python3 -c "import platform; print(platform.machine())"If the output is x86_64, you’ll be limited to PyTorch ≤ 2.2.2.
If it’s arm64, you can install the latest PyTorch.