Skip to content

Conversation

franciscojavierarceo
Copy link
Member

@franciscojavierarceo franciscojavierarceo commented Apr 28, 2025

What this PR does / why we need it:

Refactored code to make it easier toread.

Which issue(s) this PR fixes:

Misc

Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo franciscojavierarceo marked this pull request as ready for review April 28, 2025 02:16
@franciscojavierarceo franciscojavierarceo requested a review from a team as a code owner April 28, 2025 02:16
Copy link
Collaborator

@HaoXuAI HaoXuAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me.
But long term I think it's better to refactor with a factory pattern or an abstraction to avoid so many conditions check.

@franciscojavierarceo franciscojavierarceo merged commit f04872a into master Apr 28, 2025
30 of 31 checks passed
j-wine pushed a commit to j-wine/feast that referenced this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants