Skip to content

Conversation

tchughesiv
Copy link
Contributor

@tchughesiv tchughesiv commented Apr 15, 2025

What this PR does / why we need it:

Continues efforts toward a complete build from source for the feature-server image. This PR gets us almost all the way there... only 1 package remains as a binary install. This PR supports source builds for the following addional python package dependencies -

  • pydantic_core
  • watchfiles
  • rpds-py
  • cryptography
  • aiohttp
  • psycopg-c

Also, for our minimal install in the feature-server image ... we replace the psycopg-binary with a psycopg[c] install. This package is a direct replacement, is recommended in production installs, and it allows us to build the full psycopg adapter from source. This has been tested in a feature store environment with a PostgreSQL data store.
https://www.psycopg.org/psycopg3/docs/basic/install.html#local-installation

Which issue(s) this PR fixes:

Relates to #5193
Fixes #5269

Misc

A milvus-lite package source build will require enhancements from the hermeto tool in order to support fetches for the conan package manager.

We added separate release offline script/Dockerfile

source ./infra/scripts/offline-release-build.sh
# leverages sdk/python/feast/infra/feature_servers/multicloud/offline/Dockerfile.sdist.release
source ./infra/scripts/offline-binary-release-build.sh
# leverages sdk/python/feast/infra/feature_servers/multicloud/offline/Dockerfile.binary.release

@tchughesiv tchughesiv force-pushed the maturin3 branch 4 times, most recently from c16ab31 to c24b812 Compare April 17, 2025 00:57
@tchughesiv tchughesiv marked this pull request as ready for review April 17, 2025 14:00
@tchughesiv tchughesiv requested a review from a team as a code owner April 17, 2025 14:00
@tchughesiv tchughesiv enabled auto-merge (squash) April 17, 2025 14:00
@tchughesiv tchughesiv marked this pull request as draft April 17, 2025 14:28
auto-merge was automatically disabled April 17, 2025 14:28

Pull request was converted to draft

Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv tchughesiv marked this pull request as ready for review April 17, 2025 17:31
@tchughesiv tchughesiv enabled auto-merge (squash) April 17, 2025 17:31
@franciscojavierarceo
Copy link
Member

@ntkathole @jyejare can we make a ticket to follow up on Milvus?

@tchughesiv tchughesiv merged commit cc431a3 into feast-dev:master Apr 17, 2025
24 checks passed
@jyejare
Copy link
Contributor

jyejare commented Apr 18, 2025

j-wine pushed a commit to j-wine/feast that referenced this pull request Jun 7, 2025
maturin builds

Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Jacob Weinhold <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deps conflict due to sqlglot[rs] upgrade

3 participants