Skip to content

fix: Change image push to use --all-tags option #4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: Change image push to use --all-tags option #4926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/master_only.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ jobs:
component: [ feature-server-dev, feature-transformation-server, feast-operator ]
env:
REGISTRY: quay.io/feastdev-ci
IMAGE: ${{ matrix.component }}
steps:
- uses: actions/checkout@v4
- name: Set up QEMU
Expand All @@ -117,10 +116,10 @@ jobs:
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
- name: Push image
run: |
make push-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}

if [[ ${{ matrix.component }} == "feature-server-dev" ]]; then
echo "IMAGE=feature-server" >> $GITHUB_ENV
if [[ "${{ matrix.component }}" == "feature-server-dev" ]]; then
docker tag ${REGISTRY}/feature-server:${GITHUB_SHA} ${REGISTRY}/feature-server:develop
docker push ${REGISTRY}/feature-server --all-tags
else
docker tag ${REGISTRY}/${{ matrix.component }}:${GITHUB_SHA} ${REGISTRY}/${{ matrix.component }}:develop
docker push ${REGISTRY}/${{ matrix.component }} --all-tags
fi
docker tag ${REGISTRY}/${IMAGE}:${GITHUB_SHA} ${REGISTRY}/${IMAGE}:develop
docker push ${REGISTRY}/${IMAGE}:develop
Loading