Skip to content

Conversation

@franciscojavierarceo
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

@franciscojavierarceo
Copy link
Member Author

@redhatHameed can you take a look at this error? I'm trying to figure out what's causing this issue. I changed the workflow in #4891 and maybe that's causing the issue?

@franciscojavierarceo
Copy link
Member Author

will try reverting: #4900

@redhatHameed
Copy link
Contributor

@redhatHameed can you take a look at this error? I'm trying to figure out what's causing this issue. I changed the workflow in #4891 and maybe that's causing the issue?

is the docker-compose binary part of workflow or installed ?

@franciscojavierarceo
Copy link
Member Author

franciscojavierarceo commented Jan 6, 2025

@redhatHameed it's dynamically fetched and installed.

     wget https://github.com/milvus-io/milvus/releases/download/v2.5.1/milvus-standalone-docker-compose.yml -O docker-compose.yml
     docker compose up -d

@lokeshrangineni
Copy link
Contributor

I wonder why is this PR triggering the integration tests.

@lokeshrangineni
Copy link
Contributor

I wonder why is this PR triggering the integration tests.

Seems like branch is not redbased to pull latest changes related to fixing the integration test changes.

@franciscojavierarceo
Copy link
Member Author

@lokeshrangineni I used this repo to test that the pr_integration_teste.yaml was the root cause of an error. I'll close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants