Skip to content

revert: Revert "fix: Avoid XSS attack from Jinjin2's Environment()." #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

revert: Revert "fix: Avoid XSS attack from Jinjin2's Environment()." #4357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,9 +365,7 @@ def build_point_in_time_query(
full_feature_names: bool = False,
) -> str:
"""Build point-in-time query between each feature view table and the entity dataframe for PostgreSQL"""
template = Environment(autoescape=True, loader=BaseLoader()).from_string(
source=query_template
)
template = Environment(loader=BaseLoader()).from_string(source=query_template)

final_output_feature_names = list(entity_df_columns)
final_output_feature_names.extend(
Expand Down
4 changes: 1 addition & 3 deletions sdk/python/feast/infra/offline_stores/offline_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,7 @@ def build_point_in_time_query(
full_feature_names: bool = False,
) -> str:
"""Build point-in-time query between each feature view table and the entity dataframe for Bigquery and Redshift"""
template = Environment(autoescape=True, loader=BaseLoader()).from_string(
source=query_template
)
template = Environment(loader=BaseLoader()).from_string(source=query_template)

final_output_feature_names = list(entity_df_columns)
final_output_feature_names.extend(
Expand Down