Skip to content

feat: Add data source search #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023
Merged

feat: Add data source search #3449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 47 additions & 5 deletions ui/src/pages/data-sources/Index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import React, { useContext } from "react";

import {
EuiPageHeader,
EuiPageContent,
EuiPageContentBody,
EuiLoadingSpinner,
EuiPageHeader,
EuiPageContent,
EuiPageContentBody,
EuiLoadingSpinner, EuiFlexGroup, EuiFlexItem, EuiTitle, EuiFieldSearch, EuiSpacer,
} from "@elastic/eui";

import useLoadRegistry from "../../queries/useLoadRegistry";
Expand All @@ -13,6 +13,8 @@ import { useDocumentTitle } from "../../hooks/useDocumentTitle";
import RegistryPathContext from "../../contexts/RegistryPathContext";
import DataSourceIndexEmptyState from "./DataSourceIndexEmptyState";
import { DataSourceIcon32 } from "../../graphics/DataSourceIcon";
import { useSearchQuery} from "../../hooks/useSearchInputWithTags";
import { feast } from "../../protos";

const useLoadDatasources = () => {
const registryUrl = useContext(RegistryPathContext);
Expand All @@ -29,11 +31,32 @@ const useLoadDatasources = () => {
};
};

const filterFn = (data: feast.core.IDataSource[], searchTokens: string[]) => {
let filteredByTags = data;

if (searchTokens.length) {
return filteredByTags.filter((entry) => {
return searchTokens.find((token) => {
return token.length >= 3 && entry.name && entry.name.indexOf(token) >= 0;
});
});
}

return filteredByTags;
};

const Index = () => {
const { isLoading, isSuccess, isError, data } = useLoadDatasources();

useDocumentTitle(`Data Sources | Feast`);

const { searchString, searchTokens, setSearchString } = useSearchQuery();

const filterResult = data
? filterFn(data, searchTokens)
: data;


return (
<React.Fragment>
<EuiPageHeader
Expand All @@ -56,7 +79,26 @@ const Index = () => {
)}
{isError && <p>We encountered an error while loading.</p>}
{isSuccess && !data && <DataSourceIndexEmptyState />}
{isSuccess && data && <DatasourcesListingTable dataSources={data} />}
{isSuccess && data && data.length > 0 && filterResult && (
<React.Fragment>
<EuiFlexGroup>
<EuiFlexItem grow={2}>
<EuiTitle size="xs">
<h2>Search</h2>
</EuiTitle>
<EuiFieldSearch
value={searchString}
fullWidth={true}
onChange={(e) => {
setSearchString(e.target.value);
}}
/>
</EuiFlexItem>
</EuiFlexGroup>
<EuiSpacer size="m" />
<DatasourcesListingTable dataSources={filterResult} />
</React.Fragment>
)}
</EuiPageContentBody>
</EuiPageContent>
</React.Fragment>
Expand Down