chore: Relax protobuf constraints #3103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3103 +/- ##
==========================================
+ Coverage 66.93% 76.55% +9.62%
==========================================
Files 173 209 +36
Lines 15056 17399 +2343
==========================================
+ Hits 10077 13319 +3242
+ Misses 4979 4080 -899
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Kevin Zhang <[email protected]>
Signed-off-by: Kevin Zhang <[email protected]>
achals
approved these changes
Aug 18, 2022
Comment on lines
+119
to
+120
| current_version = pkg_resources.get_distribution("protobuf").version | ||
| if version.parse(current_version) < version.parse("3.20"): |
There was a problem hiding this comment.
Suggested change
| current_version = pkg_resources.get_distribution("protobuf").version | |
| if version.parse(current_version) < version.parse("3.20"): | |
| current_protobuf_version = pkg_resources.get_distribution("protobuf").version | |
| if version.parse(current_protobuf_version) < version.parse("3.20"): |
There was a problem hiding this comment.
Maybe link to any relevant issue here?
Comment on lines
+167
to
+168
| current_version = pkg_resources.get_distribution("protobuf").version | ||
| if version.parse(current_version) < version.parse("3.20"): |
Signed-off-by: Kevin Zhang <[email protected]>
Signed-off-by: Kevin Zhang <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817, kevjumba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Zhang [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3101