Skip to content

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Aug 3, 2022

What this PR does / why we need it:
For a while now, we've been using warnings as the default way to tell users a feature is experimental. This formally deprecates needing feature_store.yaml flags to enable ODFV and lambda feature servers.

Which issue(s) this PR fixes:

Fixes #

adchia added 3 commits August 3, 2022 15:19
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
@adchia adchia force-pushed the removeAlphaFlags branch from 7db2cad to 1b9a52d Compare August 3, 2022 20:20
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #3005 (3dfcd43) into master (16957ac) will decrease coverage by 17.89%.
The diff coverage is 54.54%.

@@             Coverage Diff             @@
##           master    #3005       +/-   ##
===========================================
- Coverage   77.83%   59.94%   -17.90%     
===========================================
  Files         194      193        -1     
  Lines       16567    16474       -93     
===========================================
- Hits        12895     9875     -3020     
- Misses       3672     6599     +2927     
Flag Coverage Δ
integrationtests ?
unittests 59.94% <54.54%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/errors.py 68.23% <ø> (-1.71%) ⬇️
sdk/python/feast/feature_store.py 71.26% <50.00%> (-14.46%) ⬇️
sdk/python/feast/flags_helper.py 66.66% <50.00%> (-15.69%) ⬇️
sdk/python/feast/infra/aws.py 23.07% <50.00%> (-16.93%) ⬇️
sdk/python/feast/repo_config.py 77.22% <50.00%> (-10.28%) ⬇️
sdk/python/feast/cli.py 41.69% <100.00%> (+2.08%) ⬆️
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...fline_store/test_universal_historical_retrieval.py 28.94% <0.00%> (-71.06%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) ⬇️
... and 75 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

adchia added 2 commits August 4, 2022 11:23
Signed-off-by: Danny Chiao <[email protected]>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit ce26d8b into feast-dev:master Aug 4, 2022
@adchia adchia deleted the removeAlphaFlags branch August 5, 2022 20:43
adchia added a commit that referenced this pull request Aug 10, 2022
* remove straggler references

Signed-off-by: Danny Chiao <[email protected]>

* remove straggler references

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* rebase

Signed-off-by: Danny Chiao <[email protected]>

* add lambda doc to feature server README

Signed-off-by: Danny Chiao <[email protected]>
adchia added a commit that referenced this pull request Aug 10, 2022
* remove straggler references

Signed-off-by: Danny Chiao <[email protected]>

* remove straggler references

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* rebase

Signed-off-by: Danny Chiao <[email protected]>

* add lambda doc to feature server README

Signed-off-by: Danny Chiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants