-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: Remove old way of flagging features as experimental #3005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
7db2cad
to
1b9a52d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3005 +/- ##
===========================================
- Coverage 77.83% 59.94% -17.90%
===========================================
Files 194 193 -1
Lines 16567 16474 -93
===========================================
- Hits 12895 9875 -3020
- Misses 3672 6599 +2927
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
docs/reference/feature-servers/alpha-aws-lambda-feature-server.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* remove straggler references Signed-off-by: Danny Chiao <[email protected]> * remove straggler references Signed-off-by: Danny Chiao <[email protected]> * fix Signed-off-by: Danny Chiao <[email protected]> * rebase Signed-off-by: Danny Chiao <[email protected]> * add lambda doc to feature server README Signed-off-by: Danny Chiao <[email protected]>
* remove straggler references Signed-off-by: Danny Chiao <[email protected]> * remove straggler references Signed-off-by: Danny Chiao <[email protected]> * fix Signed-off-by: Danny Chiao <[email protected]> * rebase Signed-off-by: Danny Chiao <[email protected]> * add lambda doc to feature server README Signed-off-by: Danny Chiao <[email protected]>
What this PR does / why we need it:
For a while now, we've been using warnings as the default way to tell users a feature is experimental. This formally deprecates needing
feature_store.yaml
flags to enable ODFV and lambda feature servers.Which issue(s) this PR fixes:
Fixes #