Skip to content

Conversation

creativedutchmen
Copy link
Contributor

Instead of having the URL to the registry be absolute (default to 0.0.0.0:8888), use a relative path. This means there's no SSL issues when putting the UI behind a SSL proxy, nor will it try to load it from localhost. This change allows the UI to be deployed to a central location.

Fixes #2731

@creativedutchmen creativedutchmen changed the title Made URL to registry relative, fixes #2731 fix: Made URL to registry relative, fixes #2731 Jun 2, 2022
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, creativedutchmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.40%. Comparing base (0cf3c92) to head (f114146).
Report is 1080 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
- Coverage   80.44%   80.40%   -0.04%     
==========================================
  Files         171      171              
  Lines       14571    14571              
==========================================
- Hits        11721    11716       -5     
- Misses       2850     2855       +5     
Flag Coverage Δ
integrationtests 70.87% <ø> (-0.33%) ⬇️
unittests 59.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adchia adchia merged commit 44a3f05 into feast-dev:master Jun 2, 2022
@creativedutchmen creativedutchmen deleted the bugfix/2731-remote-ui branch June 3, 2022 07:21
adchia pushed a commit that referenced this pull request Jun 13, 2022
adchia pushed a commit that referenced this pull request Jun 13, 2022
## [0.21.3](v0.21.2...v0.21.3) (2022-06-13)

### Bug Fixes

* Change online UI schema field to be optional ([#2766](#2766)) ([e6edb58](e6edb58)), closes [#2719](#2719)
* Made URL to registry relative, fixes [#2731](#2731) ([#2753](#2753)) ([a66aea8](a66aea8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to access data in Feast UI when deployed to remote instance
4 participants