Skip to content

fix: Fix Java Master #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 6, 2022
Merged

fix: Fix Java Master #2499

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2d6c96
Fix
kevjumba Apr 6, 2022
8bb0cd6
Fix?
kevjumba Apr 6, 2022
536c3c6
Update sources
kevjumba Apr 6, 2022
4677173
Fix
kevjumba Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/java-demo/feature_repo/driver_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def transformed_conv_rate(inputs: pd.DataFrame) -> pd.DataFrame:
# Define request feature view
driver_age_request_fv = RequestFeatureView(
name="driver_age",
request_source=RequestSource(
request_data_source=RequestSource(
name="driver_age", schema={"driver_age": ValueType.INT64,}
),
)
4 changes: 2 additions & 2 deletions java/serving/src/test/resources/docker-compose/feast10/definitions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from feast.feature_view import FeatureView
from feast.entity import Entity
from feast.feature_service import FeatureService
from feast.on_demand_feature_view import RequestDataSource, on_demand_feature_view
from feast.data_source import RequestSource, on_demand_feature_view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on_demand_feature_view should come from feast.on_demand_feature_view, RequestSource from feast.data_source.

Copy link
Collaborator Author

@kevjumba kevjumba Apr 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh srry, I just fixed that, didn't push yet, bc I'm running integration tests locally.

from feast import FileSource


Expand Down Expand Up @@ -40,7 +40,7 @@
)


input_request = RequestDataSource(
input_request = RequestSource(
name="vals_to_add",
schema={
"val_to_add": ValueType.INT64,
Expand Down