Skip to content

feat: Make feast PEP 561 compliant #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 22, 2022
Merged

feat: Make feast PEP 561 compliant #2405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ab245e9
add py.typed marker
tpvasconcelos Mar 14, 2022
e1578db
add py.typed to MANIFEST.in
tpvasconcelos Mar 14, 2022
e99e8b5
ignore mypy error from generated protos modules
tpvasconcelos Mar 14, 2022
1bdbe78
revert: ignore mypy error from generated protos modules
tpvasconcelos Mar 16, 2022
64de086
reorder imports
achals Mar 22, 2022
29d5272
sort imports
tpvasconcelos Mar 22, 2022
e47a32b
sort imports
tpvasconcelos Mar 22, 2022
99783f2
feat: Allow using entity's join_key in get_online_features (#2420)
pyalex Mar 21, 2022
adfe754
fix!: GetOnlineFeatureResponse in Python feature server should be con…
pyalex Mar 21, 2022
74f1e04
chore: Adding documentation on community calendar + newsletter + upda…
adchia Mar 21, 2022
b6d6afc
feat: Graduate write_to_online_store out of experimental status (#2426)
achals Mar 21, 2022
2679658
refactor!: Remove deprecated parameters from Entity and FeatureView (…
felixwang9817 Mar 21, 2022
2bfc6bb
ci: Modify release script to only do minor release for breaking chang…
felixwang9817 Mar 21, 2022
022cca1
fix: Ensure that __init__ files exist in proto dirs (#2433)
achals Mar 22, 2022
8861213
feat: Allow using entity's join_key in get_online_features (#2420)
pyalex Mar 21, 2022
aa74ee2
fix!: GetOnlineFeatureResponse in Python feature server should be con…
pyalex Mar 21, 2022
a2f4c3b
chore: Adding documentation on community calendar + newsletter + upda…
adchia Mar 21, 2022
8be62c9
feat: Graduate write_to_online_store out of experimental status (#2426)
achals Mar 21, 2022
cde237a
refactor!: Remove deprecated parameters from Entity and FeatureView (…
felixwang9817 Mar 21, 2022
849c1cb
ci: Modify release script to only do minor release for breaking chang…
felixwang9817 Mar 21, 2022
6c36f69
fix: Ensure that __init__ files exist in proto dirs (#2433)
achals Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ format-python:
cd ${ROOT_DIR}/sdk/python; python -m black --target-version py37 feast tests

lint-python:
cd ${ROOT_DIR}/sdk/python; python -m mypy feast/ tests/
cd ${ROOT_DIR}/sdk/python; python -m mypy
cd ${ROOT_DIR}/sdk/python; python -m isort feast/ tests/ --check-only
cd ${ROOT_DIR}/sdk/python; python -m flake8 feast/ tests/
cd ${ROOT_DIR}/sdk/python; python -m black --check feast tests
Expand Down
1 change: 1 addition & 0 deletions sdk/python/MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
recursive-include feast/protos/ *.py
include feast/binaries/*
recursive-include feast py.typed *.pyi
Empty file added sdk/python/feast/py.typed
View file
Open in desktop
Empty file.
3 changes: 2 additions & 1 deletion sdk/python/setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[isort]
src_paths = feast,tests
multi_line_output=3
include_trailing_comma=True
force_grid_wrap=0
Expand All @@ -16,5 +17,5 @@ select = B,C,E,F,W,T4
exclude = .git,__pycache__,docs/conf.py,dist,feast/protos

[mypy]
files=feast,test
files=feast,tests
ignore_missing_imports=true