Fixing the Java helm charts and adding a demo tutorial on how to use them #2298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2298 +/- ##
==========================================
- Coverage 86.15% 86.05% -0.10%
==========================================
Files 116 116
Lines 9820 9820
==========================================
- Hits 8460 8451 -9
- Misses 1360 1369 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
|
@adchia do you need a review here? |
|
yeah a review would be useful, but i think merging it in as is is probably fine since folks have successfully started using this new helm chart again |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adchia
added a commit
that referenced
this pull request
Feb 15, 2022
…them (#2298) * Fixing helm chart and adding java tutorial Signed-off-by: Danny Chiao <[email protected]> * fix chart version Signed-off-by: Danny Chiao <[email protected]> * test Signed-off-by: Danny Chiao <[email protected]> * Parse the overrides to not pass enabled Signed-off-by: Danny Chiao <[email protected]> * Disable secrets by default Signed-off-by: Danny Chiao <[email protected]> * Change secrets default Signed-off-by: Danny Chiao <[email protected]> * revert Signed-off-by: Danny Chiao <[email protected]> * Update README Signed-off-by: Danny Chiao <[email protected]> * finally Signed-off-by: Danny Chiao <[email protected]> * remove credentials Signed-off-by: Danny Chiao <[email protected]> * new line Signed-off-by: Danny Chiao <[email protected]> * new line Signed-off-by: Danny Chiao <[email protected]> * new line Signed-off-by: Danny Chiao <[email protected]> * Add reference from Gitbook Signed-off-by: Danny Chiao <[email protected]> * remove description Signed-off-by: Danny Chiao <[email protected]>
aht
added a commit
to aht/feast
that referenced
this pull request
Feb 23, 2022
…ents * upstream/master: (103 commits) refactor: Move create cluster script ci: Add validation for upper case PR titles Switch order of views to keep/delete to fix apply logging ci: Fix broken Prow plugin which ignores config.yaml ci: Add PR linting to ensure conventional commits are followed for PR titles Add owner field to FeatureService (feast-dev#2321) Disable Redis cluster tests (feast-dev#2327) Use PR title for commit message Add redis cluster initialziation to master github workflow (feast-dev#2317) Fix materialize bug with RedisCluster (feast-dev#2311) Add support for Dask during historical retrieval (feast-dev#1954) downgrade datatypes to 8 Update pom.xml to 0.18.2 SNAPSHOT Update changelog for 0.18.1 and update pom.xml Update helm chart version Don't require `snowflake` to always be installed (feast-dev#2309) Fixing the Java helm charts and adding a demo tutorial on how to use them (feast-dev#2298) Include infra objects in registry dump and fix Infra's from_proto (feast-dev#2295) Remove old flag warning with the python feature server (feast-dev#2300) podAnnotations Values in the feature-server chart (feast-dev#2304) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There were some out of date fields in the helm charts, and overriding them would cause breakages. Project names and registry paths were also not being passed to the feature server.
This also adds a tutorial on how to get a Java server + Redis + GCS based registry working.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: