avoid using transactions on OSS Redis #2296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: DvirDukhan [email protected]
What this PR does / why we need it:
This PR avoids using Transactions in redis-py pipelines when on a single instance mode.
redis-py pipelines are created by default as transactions https://github.com/redis/redis-py/blob/24cdd70761c7c275d5010f628f83d919bf35fc90/redis/client.py#L1020
However, on cluster mode, redis-py pipeline is built with
transaction=None
https://github.com/redis/redis-py/blob/045d5ed15305ccc44a0330e6f65f669998815598/redis/cluster.py#L698from https://redis.io/topics/transactions :
This could change can help increasing throughput when accessing a single Redis instance with multiple Feast clients.
Does this PR introduce a user-facing change?:
CC @chayim