Skip to content

Compare only specs in integration tests #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Compare only specs in integration tests #2200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
349b769
Modify registry to_dict method to allow for returning only specs
felixwang9817 Jan 7, 2022
4063d3d
Change test_cli test to keep only specs
felixwang9817 Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions sdk/python/tests/integration/registration/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ def test_universal_cli(test_repo_config) -> None:
fs = FeatureStore(repo_path=str(repo_path))
registry_dict = fs.registry.to_dict(project=project)

# Save only the specs, not the metadata.
registry_specs = {
key: [fco["spec"] for fco in value]
for key, value in registry_dict.items()
}

# entity & feature view list commands should succeed
result = runner.run(["entities", "list"], cwd=repo_path)
assertpy.assert_that(result.returncode).is_equal_to(0)
Expand Down Expand Up @@ -83,8 +89,12 @@ def test_universal_cli(test_repo_config) -> None:
)

# Confirm that registry contents have not changed.
assertpy.assert_that(registry_dict).is_equal_to(
fs.registry.to_dict(project=project)
registry_dict = fs.registry.to_dict(project=project)
assertpy.assert_that(registry_specs).is_equal_to(
{
key: [fco["spec"] for fco in value]
for key, value in registry_dict.items()
}
)

result = runner.run(["teardown"], cwd=repo_path)
Expand Down