Skip to content

Fixes large payload runtime exception in Datastore (issue 1633) #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Fixes large payload runtime exception in Datastore (issue 1633) #2181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e68521
Fixes runtime exception when feature values are larger than 1500 byte…
ptoman-pa Dec 30, 2021
58e1978
Linted
ptoman-pa Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions sdk/python/feast/infra/online_stores/datastore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,18 +196,18 @@ def _write_minibatch(
key=key, exclude_from_indexes=("created_ts", "event_ts", "values")
)

entity.update(
dict(
key=entity_key.SerializeToString(),
values={k: v.SerializeToString() for k, v in features.items()},
event_ts=utils.make_tzaware(timestamp),
created_ts=(
utils.make_tzaware(created_ts)
if created_ts is not None
else None
),
)
content_entity = datastore.Entity(
exclude_from_indexes=tuple(features.keys())
)
for k, v in features.items():
content_entity[k] = v.SerializeToString()
entity["key"] = entity_key.SerializeToString()
entity["values"] = content_entity
entity["event_ts"] = utils.make_tzaware(timestamp)
entity["created_ts"] = (
utils.make_tzaware(created_ts) if created_ts is not None else None
)

entities.append(entity)
with client.transaction():
client.put_multi(entities)
Expand Down