-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
Description
Expected Behavior
I propose we expose an optional parameter to /materialize, to specify whether full_feature_names are passed-in. This way, for projects that really use full_feature_names, the materialize flow won't break.
Current Behavior
We stumbled upon a peculiar issue while working on materializing some ODFVs. It appears deep within the flow, ODFV materialization calls get_historical_features. Why it is done, not sure. In any case, for projects where feature names collide and feature_views act as namespaces, this causes the following issue:
/materialize
raise FeatureNameCollisionError(collided_feature_refs, full_feature_names)
feast.errors.FeatureNameCollisionError: Duplicate features named <my_feature_1>
To resolve this collision, either use the full feature name by setting 'full_feature_names=True', or ensure that the features in question have different names.
Steps to reproduce
Call /materialize for any arbritrary ODFV.
Specifications
- Version:
- Platform:
- Subsystem: