Skip to content

Lint issues on master #2249

@felixwang9817

Description

@felixwang9817

Expected Behavior

make lint-python should work on master

Current Behavior

make lint-python yields the following error:

feast/feature_store.py:1440: error: Name 'FieldStatus.ValueType' is not defined
feast/feature_store.py:1493: error: Name 'FieldStatus.ValueType' is not defined

I suspect this issue was introduced by #2223, and is occurring due to some packages being out of date (most likely mypy-protobuf or something related). In particular, this kind of typing is described here, so it should be correct.

A probably related issue is that CI_REQUIRED contains mypy-protobuf==3.1.0 but DEV_REQUIRED contains mypy-protobuf==1.*.

Steps to reproduce

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions