Skip to content

Conversation

@fclairamb
Copy link
Owner

I broke them with the latest changes around the removal of mutex.

Now I'm fixing them and adding them as part of the CI.

I broke them with the latest changes around the removal of mutex.

Now I'm fixing them and adding them as part of the CI.
@fclairamb fclairamb requested review from asv, byrnedo and mgenov November 4, 2017 23:14
Copy link
Collaborator

@asv asv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny, I did not get time to push similar fix. Maybe it's worth making a Listener private?

@fclairamb
Copy link
Owner Author

This is a good point. The http.Server doesn't expose its Listener, so why should we ?

Still... I think it should be in an other PR because:

  • This is a different subject
  • It forces us to transform the API. The test framework for example makes an intensive use of the Listener (to be able to start many instances of the server as the same by letting the system decide which port we should listen on).

@fclairamb
Copy link
Owner Author

I'm merging this as this is a minor change that improves quality.

@fclairamb fclairamb merged commit e514be9 into master Nov 5, 2017
@fclairamb fclairamb deleted the passing-race-tests branch November 19, 2017 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants